Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: components/favicon/core/favicon_driver_impl.h

Issue 1118073002: Simplify FaviconDriverImpl by removing extra FaviconHandler member. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/favicon_driver_impl.h
diff --git a/components/favicon/core/favicon_driver_impl.h b/components/favicon/core/favicon_driver_impl.h
index f4a93d643b00fcf687e7677c4526b6942f0970c1..bb6d2cf3bbfee7bcb7f77c70646f50efb55f3511 100644
--- a/components/favicon/core/favicon_driver_impl.h
+++ b/components/favicon/core/favicon_driver_impl.h
@@ -83,12 +83,10 @@ class FaviconDriverImpl : public FaviconDriver {
history::HistoryService* history_service_;
bookmarks::BookmarkModel* bookmark_model_;
- // FaviconHandlers used to download the different kind of favicons. Both
- // |touch_icon_handler_| and |large_icon_handler_| may be null depending
- // on the platform or variations.
+ // FaviconHandlers used to download the different kind of favicons. The
+ // |touch_icon_handler_| may be null depending on the platform and variations.
scoped_ptr<FaviconHandler> favicon_handler_;
scoped_ptr<FaviconHandler> touch_icon_handler_;
- scoped_ptr<FaviconHandler> large_icon_handler_;
DISALLOW_COPY_AND_ASSIGN(FaviconDriverImpl);
};
« no previous file with comments | « no previous file | components/favicon/core/favicon_driver_impl.cc » ('j') | components/favicon/core/favicon_handler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698