Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1118043002: Provide an array buffer allocator to V8. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Provide an array buffer allocator to V8. This allows PDFium to work with current V8, so unpin v8 in the pdfium DEPS file. (I also re-ordered one field in CJS_Runtime, just to put two bools together (may pack tighter), and to put all the v8 stuff together). BUG=pdfium:146 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f3fecc0c686418272e49c8d51da2cb12e80bd1a2

Patch Set 1 #

Patch Set 2 : Tabify #

Total comments: 1

Patch Set 3 : Indent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 1 3 chunks +14 lines, -6 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 2 1 chunk +19 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review.
5 years, 7 months ago (2015-04-30 17:44:11 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1118043002/diff/20001/fpdfsdk/src/javascript/JS_Runtime.cpp File fpdfsdk/src/javascript/JS_Runtime.cpp (right): https://codereview.chromium.org/1118043002/diff/20001/fpdfsdk/src/javascript/JS_Runtime.cpp#newcode117 fpdfsdk/src/javascript/JS_Runtime.cpp:117: v8::Isolate::CreateParams params; nit: indentation
5 years, 7 months ago (2015-04-30 20:39:50 UTC) #3
Tom Sepez
5 years, 7 months ago (2015-04-30 21:30:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f3fecc0c686418272e49c8d51da2cb12e80bd1a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698