Implement tracing for function expressions and statements, and infer types of parameters of these c…

sdk/lib/_internal/compiler/implementation/universe/universe.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library universe;
 
 import '../elements/elements.dart';
 import '../dart2jslib.dart';
 import '../dart_types.dart';
 import '../types/types.dart';
@@ skipping 303 matching lines @@
     }
     return kind;
   }
 
   bool appliesUnnamed(Element element, Compiler compiler) {
     assert(sameNameHack(element, compiler));
     return appliesUntyped(element, compiler);
   }
 
   bool appliesUntyped(Element element, Compiler compiler) {
-    assert(sameNameHack(element, compiler));

[ngeoffray, 2013/12/10 17:11:02]

This is now also being called for closure calls, where the element name is the
closure name, and the selector name can be anything, depending on how the
closure is called.

[kasperl, 2013/12/11 07:35:35]

Should we get rid of all the sameNameHack stuff?

[ngeoffray, 2013/12/16 11:47:43]

I'll try, but some call sites do tricky things hard to work around.

     if (Elements.isUnresolved(element)) return false;
     if (isPrivateName(name) && library != element.getLibrary()) return false;
     if (element.isForeign(compiler)) return true;
     if (element.isSetter()) return isSetter();
     if (element.isGetter()) return isGetter() || isCall();
     if (element.isField()) {
       return isSetter()
           ? !element.modifiers.isFinalOrConst()
           : isGetter() || isCall();
     }
@@ skipping 336 matching lines @@
   }
 
   Selector extendIfReachesAll(Compiler compiler) {
     bool canReachAll = compiler.enabledInvokeOn
         && mask.needsNoSuchMethodHandling(this, compiler);
     return canReachAll
         ? new TypedSelector(compiler.typesTask.dynamicType, this)
         : this;
   }
 }