Issue 1117973004: Have HTMLScriptRunner's list of scripts use a transition type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1117973004: Have HTMLScriptRunner's list of scripts use a transition type. (Closed)

Created:
5 years, 7 months ago by sof

Modified:
5 years, 7 months ago

Reviewers:
haraken, oilpan-reviews

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Have HTMLScriptRunner's list of scripts use a transition type. r194793 introduced an Oilpan heap type for the ordered list of scripts-to-execute-when-finished-parsing. Until HTMLScriptRunner is always on the Oilpan heap, that's one step too far. Use the appropriate transition type instead. TBR=haraken,oilpan-reviews BUG=475801 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194840

Patch Set 1 #

Patch Set 2 : fix HTMLScriptRunner tracing #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	Source/core/html/parser/HTMLScriptRunner.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	Source/core/html/parser/HTMLScriptRunner.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

please take a look. Addresses instability showing up here https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_ASAN/18375/layout-test-results/fast/dom/Document/document-current-script-crash-log.txt

5 years, 7 months ago (2015-05-02 12:21:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117973004/20001

5 years, 7 months ago (2015-05-02 12:48:56 UTC) #3

commit-bot: I haz the power

Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=194840

5 years, 7 months ago (2015-05-02 12:51:48 UTC) #4

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages