Source/core/dom/ContainerNode.h - Issue 1117973003: parserInsertBefore and parserRemoveChild should check newChild for a parent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNode.h

Issue 1117973003: parserInsertBefore and parserRemoveChild should check newChild for a parent. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update comment. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/parser/execute-script-during-adoption-agency-removal-expected.txt ('k') | Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/ContainerNode.h

diff --git a/Source/core/dom/ContainerNode.h b/Source/core/dom/ContainerNode.h

index 5e0ba12f41246204d1f6b5d45d97f9947812f6a0..f1ed34de65a92b1f6e3074df73b00382ec15ebdd 100644

--- a/Source/core/dom/ContainerNode.h

+++ b/Source/core/dom/ContainerNode.h

@@ -100,7 +100,7 @@ public:

PassRefPtrWillBeRawPtr<RadioNodeList> radioNodeList(const AtomicString&, bool onlyMatchImgElements = false);

// These methods are only used during parsing.

- // They don't send DOM mutation events or handle reparenting.

+ // They don't send DOM mutation events or accept DocumentFragments.

void parserAppendChild(PassRefPtrWillBeRawPtr<Node>);

void parserRemoveChild(Node&);

void parserInsertBefore(PassRefPtrWillBeRawPtr<Node> newChild, Node& refChild);