Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1117953003: Simple CL to Compute bounds in GrContext::drawVertices (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simple CL to Compute bounds in GrContext::drawVertices BUG=skia: Committed: https://skia.googlesource.com/skia/+/a09c0461463a5976908af5232b755e1663b972bf

Patch Set 1 #

Patch Set 2 : use bounds #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/gpu/GrContext.cpp View 1 2 chunks +8 lines, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
joshualitt
ptal, I will file a bug for us to try and bubble up bounds to ...
5 years, 7 months ago (2015-04-30 20:47:40 UTC) #2
robertphillips
lgtm
5 years, 7 months ago (2015-04-30 20:53:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117953003/20001
5 years, 7 months ago (2015-04-30 20:54:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/a09c0461463a5976908af5232b755e1663b972bf
5 years, 7 months ago (2015-04-30 21:03:08 UTC) #6
bsalomon
5 years, 7 months ago (2015-04-30 21:05:30 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1117953003/diff/20001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/1117953003/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1136: // TODO figure out bounds
rm this comment? (maybe in the bounds into batch cl)

Powered by Google App Engine
This is Rietveld 408576698