Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1117923002: Looks like rssPages * pageSize is overflowing on 32-bit Linux... (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
rmistry, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Looks like rssPages * pageSize is overflowing on 32-bit Linux... ... resulting in apparently negative memory usage: (-2040/2058MB 5867) 1.81s serialize-8888 skp top25desk_google_com_calendar_.skp Turns out long is 32-bit there, long long is 64-bit. NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f1d6df772ee241c67e29b0d6598576e38551a716

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/ProcStats.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117923002/1
5 years, 7 months ago (2015-04-30 14:22:15 UTC) #2
mtklein_C
Failed 32-bit run is expected... what's fixed is its log.
5 years, 7 months ago (2015-04-30 14:32:22 UTC) #5
rmistry
LGTM
5 years, 7 months ago (2015-04-30 14:33:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117923002/1
5 years, 7 months ago (2015-04-30 14:35:13 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 14:35:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f1d6df772ee241c67e29b0d6598576e38551a716

Powered by Google App Engine
This is Rietveld 408576698