Issue 11179003: Reapply geolocation network protocol changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11179003: Reapply geolocation network protocol changes. (Closed)

Created:
8 years, 2 months ago by John Knottenbelt

Modified:
8 years, 2 months ago

Reviewers:
bulach, kareng, joi, Jói

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/branches/1271/src/

Visibility:
Public.

Reapply geolocation network protocol changes. This CL reapplys revisions: http://src.chromium.org/viewvc/chrome?view=rev&revision=156313 http://src.chromium.org/viewvc/chrome?view=rev&revision=156273 Which is effectively a revert of revision 158817 and revision 158819. The new geolocation backend has been fixed, and no changes were required to the code in Chromium, so it desirable to have M23 using the new geolocation protocol. BUG=152428 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162699

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+240 lines, -201 lines)			Patch
M	chrome/browser/geolocation/chrome_access_token_store.cc	View	3 chunks	+19 lines, -8 lines	0 comments	Download
M	content/browser/geolocation/location_arbitrator.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/geolocation/location_arbitrator.cc	View	4 chunks	+8 lines, -3 lines	0 comments	Download
M	content/browser/geolocation/network_location_provider_unittest.cc	View	14 chunks	+148 lines, -89 lines	0 comments	Download
M	content/browser/geolocation/network_location_request.cc	View	13 chunks	+63 lines, -101 lines	0 comments	Download

Total messages: 6 (0 generated)

John Knottenbelt

I think the try bots are not set up to try branch patches. I have ...

8 years, 2 months ago (2012-10-16 13:52:47 UTC) #2

John Knottenbelt

Karen, please let me know if you object to me landing this on M23 branch. ...

8 years, 2 months ago (2012-10-17 10:13:12 UTC) #5

Committed revision 162699