components/renderer_context_menu/render_view_context_menu_base.h - Issue 1117893002: Moving extension code out of "components/" to avoid layering violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/renderer_context_menu/render_view_context_menu_base.h

Issue 1117893002: Moving extension code out of "components/" to avoid layering violations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_context_menu/render_view_context_menu.cc ('K') | « components/renderer_context_menu/context_menu_content_type.cc ('k') | components/renderer_context_menu/render_view_context_menu_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/renderer_context_menu/render_view_context_menu_base.h

diff --git a/components/renderer_context_menu/render_view_context_menu_base.h b/components/renderer_context_menu/render_view_context_menu_base.h

index 61dfbe4644bb28216b0d88f74b3f90ceef7fae47..e4f89613b743f793d98ad32ad27827d785b9781f 100644

--- a/components/renderer_context_menu/render_view_context_menu_base.h

+++ b/components/renderer_context_menu/render_view_context_menu_base.h

@@ -170,10 +170,6 @@ class RenderViewContextMenuBase : public ui::SimpleMenuModel::Delegate,

content::ContextMenuParams params_;

content::WebContents* source_web_contents_;

- // In the case of a MimeHandlerView this will point to the WebContents that

- // embeds the MimeHandlerViewGuest. Otherwise this will be the same as

- // source_web_contents_.

- content::WebContents* embedder_web_contents_;

content::BrowserContext* browser_context_;

ui::SimpleMenuModel menu_model_;