Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1117863003: Convert the remaining three SpdyNetworkTransactionTests to SequencedSocketData (Closed)

Created:
5 years, 7 months ago by Ryan Hamilton
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert the remaining three SpdyNetworkTransactionTests to SequencedSocketData Once the DNS test conversion CL lands, I'll be able to remove DelayedSocketData. Committed: https://crrev.com/acdcbdcbf11083ffea59d22938a9497ca74e6cbb Cr-Commit-Position: refs/heads/master@{#330290}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+666 lines, -708 lines) Patch
M net/http/http_network_transaction_unittest.cc View 1 4 chunks +18 lines, -10 lines 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 1 3 chunks +27 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 6 chunks +36 lines, -11 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 139 chunks +580 lines, -687 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ryan Hamilton
5 years, 7 months ago (2015-05-04 14:45:37 UTC) #2
ramant (doing other things)
lgtm
5 years, 7 months ago (2015-05-04 17:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117863003/20001
5 years, 7 months ago (2015-05-16 17:10:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-16 17:16:08 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:32:02 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/acdcbdcbf11083ffea59d22938a9497ca74e6cbb
Cr-Commit-Position: refs/heads/master@{#330290}

Powered by Google App Engine
This is Rietveld 408576698