Issue 111783003: Move all GYP->GN argument conversion to Python.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 111783003: Move all GYP->GN argument conversion to Python. (Closed)

Created:
7 years ago by brettw

Modified:
7 years ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move all GYP->GN argument conversion to Python. This moves build variable remapping from C++ to the Python wrapper. This will be much more scaleable since we can add stuff to the script atomically without rolling out new binaries. R=scottmg@chromium.org, scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240732

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -90 lines)			Patch
		build/gyp_chromium	View		3 chunks	+26 lines, -9 lines	0 comments	Download
		tools/gn/command_gyp.cc	View	1 2 3 4	3 chunks	+0 lines, -81 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

Upload is acting funny so you will have to look at the diffs rather than ...

7 years ago (2013-12-12 23:46:38 UTC) #1

Message was sent while issue was closed.

Committed patchset #6 manually as r240732 (presubmit successful).

Expand Messages | Collapse Messages