Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 111773002: Revert 239784 "Make page_cycler.py fully measure memory for each..." (Closed)

Created:
7 years ago by Philippe
Modified:
7 years ago
Reviewers:
Philippe
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 239784 "Make page_cycler.py fully measure memory for each..." > Make page_cycler.py fully measure memory for each page. > > Telemetry makes the distinction between metrics collected for each page and for > each page set. The fine-grained memory metrics were collected only per page set > (although there was some histogram data collected per page). > > This CL makes the memory metric module systematically report the whole data per > page (and not only per page set) so that we can measure pages independently. > The per page set memory metric collection is now a no-op. > > BUG=323494 > > Review URL: https://codereview.chromium.org/91573003 TBR=pliard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -54 lines) Patch
M trunk/src/build/android/pylib/android_commands.py View 2 chunks +16 lines, -0 lines 0 comments Download
M trunk/src/tools/perf/measurements/media.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/tools/perf/measurements/memory.py View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/tools/perf/measurements/memory_multi_tab.py View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/tools/perf/measurements/page_cycler.py View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/tools/perf/metrics/memory.py View 4 chunks +30 lines, -28 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/core/browser.py View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/tools/telemetry/telemetry/core/platform/android_platform_backend.py View 2 chunks +1 line, -13 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/core/platform/mac_platform_backend.py View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/core/platform/platform_backend.py View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Philippe
7 years ago (2013-12-10 16:23:09 UTC) #1
Philippe
7 years ago (2013-12-10 16:23:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r239791.

Powered by Google App Engine
This is Rietveld 408576698