Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1117713002: Add shift to InternalArray and InternalPackedArray (Closed)

Created:
5 years, 7 months ago by domenic
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add shift to InternalArray and InternalPackedArray It's useful for queue-like data structures. R=yangguo@chromium.org BUG= Committed: https://crrev.com/f47f88ad0e0f565ff6d35b0704e56b39fe594311 Cr-Commit-Position: refs/heads/master@{#28146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/array.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
domenic
5 years, 7 months ago (2015-04-29 17:26:25 UTC) #1
Yang
lgtm
5 years, 7 months ago (2015-04-30 06:45:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117713002/1
5 years, 7 months ago (2015-04-30 07:45:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 08:07:21 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 08:07:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f47f88ad0e0f565ff6d35b0704e56b39fe594311
Cr-Commit-Position: refs/heads/master@{#28146}

Powered by Google App Engine
This is Rietveld 408576698