Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: net/url_request/test_url_fetcher_factory.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/test_url_fetcher_factory.h ('k') | net/url_request/url_fetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/test_url_fetcher_factory.cc
diff --git a/net/url_request/test_url_fetcher_factory.cc b/net/url_request/test_url_fetcher_factory.cc
index 6dc9367ad473ffc68abbee3d689690de12476c95..207d2857d5d6afaa2f1aca704520c6e93c16ea0b 100644
--- a/net/url_request/test_url_fetcher_factory.cc
+++ b/net/url_request/test_url_fetcher_factory.cc
@@ -300,7 +300,7 @@ TestURLFetcherFactory::TestURLFetcherFactory()
TestURLFetcherFactory::~TestURLFetcherFactory() {}
-URLFetcher* TestURLFetcherFactory::CreateURLFetcher(
+scoped_ptr<URLFetcher> TestURLFetcherFactory::CreateURLFetcher(
int id,
const GURL& url,
URLFetcher::RequestType request_type,
@@ -310,7 +310,7 @@ URLFetcher* TestURLFetcherFactory::CreateURLFetcher(
fetcher->set_owner(this);
fetcher->SetDelegateForTests(delegate_for_tests_);
fetchers_[id] = fetcher;
- return fetcher;
+ return scoped_ptr<URLFetcher>(fetcher);
}
TestURLFetcher* TestURLFetcherFactory::GetFetcherByID(int id) const {
@@ -399,7 +399,7 @@ scoped_ptr<FakeURLFetcher> FakeURLFetcherFactory::DefaultFakeURLFetcherCreator(
FakeURLFetcherFactory::~FakeURLFetcherFactory() {}
-URLFetcher* FakeURLFetcherFactory::CreateURLFetcher(
+scoped_ptr<URLFetcher> FakeURLFetcherFactory::CreateURLFetcher(
int id,
const GURL& url,
URLFetcher::RequestType request_type,
@@ -415,11 +415,10 @@ URLFetcher* FakeURLFetcherFactory::CreateURLFetcher(
}
}
- scoped_ptr<FakeURLFetcher> fake_fetcher =
- creator_.Run(url, d, it->second.response_data,
- it->second.response_code, it->second.status);
- // TODO: Make URLFetcherFactory::CreateURLFetcher return a scoped_ptr
- return fake_fetcher.release();
+ scoped_ptr<URLFetcher> fake_fetcher =
+ creator_.Run(url, d, it->second.response_data, it->second.response_code,
+ it->second.status);
+ return fake_fetcher;
}
void FakeURLFetcherFactory::SetFakeResponse(
@@ -443,12 +442,12 @@ URLFetcherImplFactory::URLFetcherImplFactory() {}
URLFetcherImplFactory::~URLFetcherImplFactory() {}
-URLFetcher* URLFetcherImplFactory::CreateURLFetcher(
+scoped_ptr<URLFetcher> URLFetcherImplFactory::CreateURLFetcher(
int id,
const GURL& url,
URLFetcher::RequestType request_type,
URLFetcherDelegate* d) {
- return new URLFetcherImpl(url, request_type, d);
+ return scoped_ptr<URLFetcher>(new URLFetcherImpl(url, request_type, d));
}
} // namespace net
« no previous file with comments | « net/url_request/test_url_fetcher_factory.h ('k') | net/url_request/url_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698