content/browser/speech/google_one_shot_remote_engine.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/google_one_shot_remote_engine.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/geolocation/network_location_request.cc ('k') | content/browser/speech/google_streaming_remote_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/google_one_shot_remote_engine.cc

diff --git a/content/browser/speech/google_one_shot_remote_engine.cc b/content/browser/speech/google_one_shot_remote_engine.cc

index a74a60dedf3269900aa4e5e7dc169ab4e2ca3173..77f5c2cb6f6c90001d1c161ac3c5bc32dab0f7a0 100644

--- a/content/browser/speech/google_one_shot_remote_engine.cc

+++ b/content/browser/speech/google_one_shot_remote_engine.cc

@@ -210,10 +210,8 @@ void GoogleOneShotRemoteEngine::StartRecognition() {

config_.audio_sample_rate,

config_.audio_num_bits_per_sample));

DCHECK(encoder_.get());

- url_fetcher_.reset(net::URLFetcher::Create(url_fetcher_id_for_tests,

- url,

- net::URLFetcher::POST,

- this));

+ url_fetcher_ = net::URLFetcher::Create(url_fetcher_id_for_tests, url,

+ net::URLFetcher::POST, this);

url_fetcher_->SetChunkedUpload(encoder_->mime_type());

url_fetcher_->SetRequestContext(url_context_.get());

url_fetcher_->SetReferrer(config_.origin_url);