components/update_client/request_sender.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/request_sender.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/core/browser/translate_url_fetcher.cc ('k') | components/update_client/url_fetcher_downloader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/update_client/request_sender.cc

diff --git a/components/update_client/request_sender.cc b/components/update_client/request_sender.cc

index 726c2faea6d23174d9ccb80048832106033a6e9d..6b89ca7e94d4b8b4bd6d20f1aa4a9db54537a1c2 100644

--- a/components/update_client/request_sender.cc

+++ b/components/update_client/request_sender.cc

@@ -46,8 +46,8 @@ void RequestSender::SendInternal() {

DCHECK(cur_url_->is_valid());

DCHECK(thread_checker_.CalledOnValidThread());

- url_fetcher_.reset(SendProtocolRequest(*cur_url_, request_string_, this,

- config_.RequestContext()));

+ url_fetcher_ = SendProtocolRequest(*cur_url_, request_string_, this,

+ config_.RequestContext());

}

void RequestSender::OnURLFetchComplete(const net::URLFetcher* source) {

« no previous file with comments | « components/translate/core/browser/translate_url_fetcher.cc ('k') | components/update_client/url_fetcher_downloader.cc » ('j') | no next file with comments »