components/policy/core/common/cloud/external_policy_data_fetcher.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/external_policy_data_fetcher.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/device_management_service.cc ('k') | components/policy/core/common/cloud/user_info_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/external_policy_data_fetcher.cc

diff --git a/components/policy/core/common/cloud/external_policy_data_fetcher.cc b/components/policy/core/common/cloud/external_policy_data_fetcher.cc

index b8403b86ea25889e4703e6a9ad88d54b6de05ad0..7dd4988af79849e654f1c8c1c5b607f3d8d5cddb 100644

--- a/components/policy/core/common/cloud/external_policy_data_fetcher.cc

+++ b/components/policy/core/common/cloud/external_policy_data_fetcher.cc

@@ -170,8 +170,9 @@ scoped_ptr<ExternalPolicyDataFetcher>

void ExternalPolicyDataFetcherBackend::StartJob(

ExternalPolicyDataFetcher::Job* job) {

DCHECK(io_task_runner_->RunsTasksOnCurrentThread());

- net::URLFetcher* fetcher = net::URLFetcher::Create(

- ++last_fetch_id_, job->url, net::URLFetcher::GET, this);

+ net::URLFetcher* fetcher =

+ net::URLFetcher::Create(++last_fetch_id_, job->url, net::URLFetcher::GET,

+ this).release();

fetcher->SetRequestContext(request_context_.get());

fetcher->SetLoadFlags(net::LOAD_BYPASS_CACHE | net::LOAD_DISABLE_CACHE |

net::LOAD_DO_NOT_SAVE_COOKIES |