components/metrics/net/net_metrics_log_uploader.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/net/net_metrics_log_uploader.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/metrics/net/net_metrics_log_uploader.cc

diff --git a/components/metrics/net/net_metrics_log_uploader.cc b/components/metrics/net/net_metrics_log_uploader.cc

index cf50077370f813fe2727263de8f92a3bce10ee49..9d0027e298b34af80702d74c60cb3db728198b87 100644

--- a/components/metrics/net/net_metrics_log_uploader.cc

+++ b/components/metrics/net/net_metrics_log_uploader.cc

@@ -39,8 +39,8 @@ NetMetricsLogUploader::~NetMetricsLogUploader() {

bool NetMetricsLogUploader::UploadLog(const std::string& compressed_log_data,

const std::string& log_hash) {

- current_fetch_.reset(

- net::URLFetcher::Create(GURL(server_url_), net::URLFetcher::POST, this));

+ current_fetch_ =

+ net::URLFetcher::Create(GURL(server_url_), net::URLFetcher::POST, this);

current_fetch_->SetRequestContext(request_context_getter_);

current_fetch_->SetUploadData(mime_type_, compressed_log_data);

« no previous file with comments | « components/invalidation/gcm_network_channel.cc ('k') | components/omnibox/base_search_provider.cc » ('j') | no next file with comments »