Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/dom_distiller/core/distiller_url_fetcher.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/core/distiller_url_fetcher.h ('k') | components/domain_reliability/uploader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/core/distiller_url_fetcher.cc
diff --git a/components/dom_distiller/core/distiller_url_fetcher.cc b/components/dom_distiller/core/distiller_url_fetcher.cc
index 8c1998da80473056016d1fe5f920273ef95f32d4..f60efd7d68c817fe42cb791c2bd86d06ce83160b 100644
--- a/components/dom_distiller/core/distiller_url_fetcher.cc
+++ b/components/dom_distiller/core/distiller_url_fetcher.cc
@@ -39,14 +39,14 @@ void DistillerURLFetcher::FetchURL(const std::string& url,
// Don't allow a fetch if one is pending.
DCHECK(!url_fetcher_ || !url_fetcher_->GetStatus().is_io_pending());
callback_ = callback;
- url_fetcher_.reset(CreateURLFetcher(context_getter_, url));
+ url_fetcher_ = CreateURLFetcher(context_getter_, url);
url_fetcher_->Start();
}
-URLFetcher* DistillerURLFetcher::CreateURLFetcher(
+scoped_ptr<URLFetcher> DistillerURLFetcher::CreateURLFetcher(
net::URLRequestContextGetter* context_getter,
const std::string& url) {
- net::URLFetcher* fetcher =
+ scoped_ptr<net::URLFetcher> fetcher =
URLFetcher::Create(GURL(url), URLFetcher::GET, this);
fetcher->SetRequestContext(context_getter);
static const int kMaxRetries = 5;
« no previous file with comments | « components/dom_distiller/core/distiller_url_fetcher.h ('k') | components/domain_reliability/uploader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698