chromeos/geolocation/simple_geolocation_request.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/geolocation/simple_geolocation_request.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromeos/geolocation/simple_geolocation_request.cc

diff --git a/chromeos/geolocation/simple_geolocation_request.cc b/chromeos/geolocation/simple_geolocation_request.cc

index f5720965bd117357be1e849d2bb8de28f0de1869..ee7692f9d830596064784e0187beb2bb9c59d099 100644

--- a/chromeos/geolocation/simple_geolocation_request.cc

+++ b/chromeos/geolocation/simple_geolocation_request.cc

@@ -295,8 +295,8 @@ void SimpleGeolocationRequest::StartRequest() {

RecordUmaEvent(SIMPLE_GEOLOCATION_REQUEST_EVENT_REQUEST_START);

++retries_;

- url_fetcher_.reset(

- net::URLFetcher::Create(request_url_, net::URLFetcher::POST, this));

+ url_fetcher_ =

+ net::URLFetcher::Create(request_url_, net::URLFetcher::POST, this);

url_fetcher_->SetRequestContext(url_context_getter_.get());

url_fetcher_->SetUploadData("application/json",

std::string(kSimpleGeolocationRequestBody));

« no previous file with comments | « chrome/test/chromedriver/net/net_util.cc ('k') | chromeos/timezone/timezone_request.cc » ('j') | no next file with comments »