chrome/browser/tracing/crash_service_uploader.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tracing/crash_service_uploader.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/sync_test.cc ('k') | chrome/browser/ui/app_list/search/common/json_response_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tracing/crash_service_uploader.cc

diff --git a/chrome/browser/tracing/crash_service_uploader.cc b/chrome/browser/tracing/crash_service_uploader.cc

index ed408d516ea063eea85c3001874817569da37d22..c0983ea3c37fe23a95fe2d695e3fa12d20a0530d 100644

--- a/chrome/browser/tracing/crash_service_uploader.cc

+++ b/chrome/browser/tracing/crash_service_uploader.cc

@@ -256,8 +256,8 @@ void TraceCrashServiceUploader::CreateAndStartURLFetcher(

content_type.append("; boundary=");

content_type.append(kMultipartBoundary);

- url_fetcher_.reset(

- net::URLFetcher::Create(GURL(upload_url), net::URLFetcher::POST, this));

+ url_fetcher_ =

+ net::URLFetcher::Create(GURL(upload_url), net::URLFetcher::POST, this);

url_fetcher_->SetRequestContext(request_context_);

url_fetcher_->SetUploadData(content_type, post_data);

url_fetcher_->Start();