Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Unified Diff: chrome/browser/safe_browsing/two_phase_uploader.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_test.cc ('k') | chrome/browser/spellchecker/feedback_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/two_phase_uploader.cc
diff --git a/chrome/browser/safe_browsing/two_phase_uploader.cc b/chrome/browser/safe_browsing/two_phase_uploader.cc
index ac79e41f5705675e0955507977cad89c31cd5bba..aafecece4019e3dfae3eedf672e681aab0ed85a1 100644
--- a/chrome/browser/safe_browsing/two_phase_uploader.cc
+++ b/chrome/browser/safe_browsing/two_phase_uploader.cc
@@ -160,8 +160,8 @@ void TwoPhaseUploaderImpl::OnURLFetchUploadProgress(
void TwoPhaseUploaderImpl::UploadMetadata() {
DCHECK(CalledOnValidThread());
state_ = UPLOAD_METADATA;
- url_fetcher_.reset(net::URLFetcher::Create(base_url_, net::URLFetcher::POST,
- this));
+ url_fetcher_ =
+ net::URLFetcher::Create(base_url_, net::URLFetcher::POST, this);
url_fetcher_->SetRequestContext(url_request_context_getter_.get());
url_fetcher_->SetExtraRequestHeaders(kStartHeader);
url_fetcher_->SetUploadData(kUploadContentType, metadata_);
@@ -172,8 +172,8 @@ void TwoPhaseUploaderImpl::UploadFile() {
DCHECK(CalledOnValidThread());
state_ = UPLOAD_FILE;
- url_fetcher_.reset(net::URLFetcher::Create(upload_url_, net::URLFetcher::PUT,
- this));
+ url_fetcher_ =
+ net::URLFetcher::Create(upload_url_, net::URLFetcher::PUT, this);
url_fetcher_->SetRequestContext(url_request_context_getter_.get());
url_fetcher_->SetUploadFilePath(
kUploadContentType, file_path_, 0, kuint64max, file_task_runner_);
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_test.cc ('k') | chrome/browser/spellchecker/feedback_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698