chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc b/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc

index 88b17b00067ce4e4a257c01abd6144761db67a85..b220af0bdfc7382ba3184f7137d1318473b23235 100644

--- a/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc

+++ b/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc

@@ -84,7 +84,7 @@ void WriteFromUrlOperation::Download(const base::Closure& continuation) {

// Store the URL fetcher on this object so that it is destroyed before this

// object is.

- url_fetcher_.reset(net::URLFetcher::Create(url_, net::URLFetcher::GET, this));

+ url_fetcher_ = net::URLFetcher::Create(url_, net::URLFetcher::GET, this);

url_fetcher_->SetRequestContext(request_context_);

url_fetcher_->SaveResponseToFileAtPath(

« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/extensions/blacklist_state_fetcher.cc » ('j') | no next file with comments »