ios/chrome/browser/net/image_fetcher.mm - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/net/image_fetcher.mm

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/devtools_ui.cc ('K') | « google_apis/gcm/engine/unregistration_request.cc ('k') | ios/chrome/browser/net/retryable_url_fetcher.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/net/image_fetcher.mm

diff --git a/ios/chrome/browser/net/image_fetcher.mm b/ios/chrome/browser/net/image_fetcher.mm

index 89f59c7dc138c406529002d615a070cc405ae5ad..edf205cdc46046e12b8888eeeaf1bf60004f5c29 100644

--- a/ios/chrome/browser/net/image_fetcher.mm

+++ b/ios/chrome/browser/net/image_fetcher.mm

@@ -83,9 +83,8 @@ void ImageFetcher::StartDownload(

const std::string& referrer,

net::URLRequest::ReferrerPolicy referrer_policy) {

DCHECK(request_context_getter_.get());

- net::URLFetcher* fetcher = net::URLFetcher::Create(url,

- net::URLFetcher::GET,

- this);

+ net::URLFetcher* fetcher =

+ net::URLFetcher::Create(url, net::URLFetcher::GET, this).release();

downloads_in_progress_[fetcher] = [callback copy];

fetcher->SetLoadFlags(

net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES |

« chrome/browser/ui/webui/devtools_ui.cc ('K') | « google_apis/gcm/engine/unregistration_request.cc ('k') | ios/chrome/browser/net/retryable_url_fetcher.mm » ('j') | no next file with comments »