components/password_manager/core/browser/affiliation_fetcher.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/affiliation_fetcher.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/devtools_ui.cc ('K') | « components/omnibox/search_provider.cc ('k') | components/policy/core/common/cloud/device_management_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/affiliation_fetcher.cc

diff --git a/components/password_manager/core/browser/affiliation_fetcher.cc b/components/password_manager/core/browser/affiliation_fetcher.cc

index 53069fa9fbaa3689b43aa367574dfdaf207db405..943724bfab0f5020bd30dc1fb80c48746fa0cefa 100644

--- a/components/password_manager/core/browser/affiliation_fetcher.cc

+++ b/components/password_manager/core/browser/affiliation_fetcher.cc

@@ -88,8 +88,8 @@ void AffiliationFetcher::SetFactoryForTesting(

void AffiliationFetcher::StartRequest() {

DCHECK(!fetcher_);

- fetcher_.reset(

- net::URLFetcher::Create(BuildQueryURL(), net::URLFetcher::POST, this));

+ fetcher_ =

+ net::URLFetcher::Create(BuildQueryURL(), net::URLFetcher::POST, this);

fetcher_->SetRequestContext(request_context_getter_.get());

fetcher_->SetUploadData("application/x-protobuf", PreparePayload());

fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES |