components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/devtools_ui.cc ('K') | « components/copresence/rpc/http_post.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

index fe8b897d18613d1b7b2f186e32e0625d40f73a84..20154b7923b5a34f6df2f23adde6aaa825af9f3f 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

@@ -69,8 +69,8 @@ class SecureProxyChecker : public net::URLFetcherDelegate {

void CheckIfSecureProxyIsAllowed(const GURL& secure_proxy_check_url,

FetcherResponseCallback fetcher_callback) {

- fetcher_.reset(net::URLFetcher::Create(secure_proxy_check_url,

- net::URLFetcher::GET, this));

+ fetcher_ = net::URLFetcher::Create(secure_proxy_check_url,

+ net::URLFetcher::GET, this);

fetcher_->SetLoadFlags(net::LOAD_DISABLE_CACHE | net::LOAD_BYPASS_PROXY);

fetcher_->SetRequestContext(url_request_context_getter_.get());

// Configure max retries to be at most kMaxRetries times for 5xx errors.