components/captive_portal/captive_portal_detector.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/captive_portal/captive_portal_detector.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/devtools_ui.cc ('K') | « components/autofill/core/browser/wallet/real_pan_wallet_client.cc ('k') | components/copresence/rpc/http_post.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/captive_portal/captive_portal_detector.cc

diff --git a/components/captive_portal/captive_portal_detector.cc b/components/captive_portal/captive_portal_detector.cc

index b7b8668e5fa639615e6450d8520aef9a7d0d8ae9..ceeffe6b728c004d8e2fe50054de01d83bb80b7e 100644

--- a/components/captive_portal/captive_portal_detector.cc

+++ b/components/captive_portal/captive_portal_detector.cc

@@ -34,10 +34,7 @@ void CaptivePortalDetector::DetectCaptivePortal(

detection_callback_ = detection_callback;

// The first 0 means this can use a TestURLFetcherFactory in unit tests.

- url_fetcher_.reset(net::URLFetcher::Create(0,

- url,

- net::URLFetcher::GET,

- this));

+ url_fetcher_ = net::URLFetcher::Create(0, url, net::URLFetcher::GET, this);

url_fetcher_->SetAutomaticallyRetryOn5xx(false);

url_fetcher_->SetRequestContext(request_context_.get());