components/autofill/core/browser/autofill_download_manager.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_download_manager.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/devtools_ui.cc ('K') | « components/autofill/content/browser/wallet/wallet_signin_helper.cc ('k') | components/autofill/core/browser/wallet/real_pan_wallet_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_download_manager.cc

diff --git a/components/autofill/core/browser/autofill_download_manager.cc b/components/autofill/core/browser/autofill_download_manager.cc

index afe5679e49ddbdc2b2fcbd86a0f5a76a08f821d7..877423448b1dccabb272c1d6d78d3d8b6b0bce4d 100644

--- a/components/autofill/core/browser/autofill_download_manager.cc

+++ b/components/autofill/core/browser/autofill_download_manager.cc

@@ -177,9 +177,9 @@ bool AutofillDownloadManager::StartRequest(

// Id is ignored for regular chrome, in unit test id's for fake fetcher

// factory will be 0, 1, 2, ...

- net::URLFetcher* fetcher = net::URLFetcher::Create(

- fetcher_id_for_unittest_++, request_url, net::URLFetcher::POST,

- this);

+ net::URLFetcher* fetcher =

+ net::URLFetcher::Create(fetcher_id_for_unittest_++, request_url,

+ net::URLFetcher::POST, this).release();

url_fetchers_[fetcher] = request_data;

fetcher->SetAutomaticallyRetryOn5xx(false);

fetcher->SetRequestContext(request_context);