chromeos/timezone/timezone_request.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/timezone/timezone_request.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/devtools_ui.cc ('K') | « chromeos/geolocation/simple_geolocation_request.cc ('k') | cloud_print/gcp20/prototype/cloud_print_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/timezone/timezone_request.cc

diff --git a/chromeos/timezone/timezone_request.cc b/chromeos/timezone/timezone_request.cc

index c530e46c0897fcc6b4805adb9885ef9f46713fc8..0a41f9fb05f7f9dbd28587a7bd988e8045387d30 100644

--- a/chromeos/timezone/timezone_request.cc

+++ b/chromeos/timezone/timezone_request.cc

@@ -332,8 +332,8 @@ void TimeZoneRequest::StartRequest() {

request_started_at_ = base::Time::Now();

++retries_;

- url_fetcher_.reset(

- net::URLFetcher::Create(request_url_, net::URLFetcher::GET, this));

+ url_fetcher_ =

+ net::URLFetcher::Create(request_url_, net::URLFetcher::GET, this);

url_fetcher_->SetRequestContext(url_context_getter_.get());

url_fetcher_->SetLoadFlags(net::LOAD_BYPASS_CACHE |

net::LOAD_DISABLE_CACHE |