chrome/service/cloud_print/cloud_print_url_fetcher.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_url_fetcher.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/service/cloud_print/cloud_print_url_fetcher.cc

diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.cc b/chrome/service/cloud_print/cloud_print_url_fetcher.cc

index b1f0b51c9bedc50aba66f5e5a9fc6cdc65215b73..d095635f83e73f16dc65db24dd3bc0e1584ad185 100644

--- a/chrome/service/cloud_print/cloud_print_url_fetcher.cc

+++ b/chrome/service/cloud_print/cloud_print_url_fetcher.cc

@@ -263,7 +263,7 @@ void CloudPrintURLFetcher::StartRequestHelper(

REQUEST_MAX);

// Persist the additional headers in case we need to retry the request.

additional_headers_ = additional_headers;

- request_.reset(net::URLFetcher::Create(0, url, request_type, this));

+ request_ = net::URLFetcher::Create(0, url, request_type, this);

request_->SetRequestContext(GetRequestContextGetter());

// Since we implement our own retry logic, disable the retry in URLFetcher.

request_->SetAutomaticallyRetryOn5xx(false);

« chrome/browser/ui/webui/devtools_ui.cc ('K') | « chrome/browser/ui/webui/devtools_ui.cc ('k') | chrome/test/chromedriver/net/net_util.cc » ('j') | no next file with comments »