chrome/browser/safe_browsing/download_protection_service.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/client_side_detection_service.cc ('K') | « chrome/browser/safe_browsing/client_side_detection_service.cc ('k') | chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc » ('j') | chrome/browser/safe_browsing/ping_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service.cc b/chrome/browser/safe_browsing/download_protection_service.cc

index dd4083f9be5172ca354675efe6855b0b0ba61844..f4fbfec6996878d49c02e284dc82bd8f912f61db 100644

--- a/chrome/browser/safe_browsing/download_protection_service.cc

+++ b/chrome/browser/safe_browsing/download_protection_service.cc

@@ -781,10 +781,9 @@ class DownloadProtectionService::CheckClientDownloadRequest

DVLOG(2) << "Sending a request for URL: "

<< item_->GetUrlChain().back();

- fetcher_.reset(net::URLFetcher::Create(0 /* ID used for testing */,

- GetDownloadRequestUrl(),

- net::URLFetcher::POST,

- this));

+ fetcher_ = net::URLFetcher::Create(0 /* ID used for testing */,

+ GetDownloadRequestUrl(),

+ net::URLFetcher::POST, this);

fetcher_->SetLoadFlags(net::LOAD_DISABLE_CACHE);

fetcher_->SetAutomaticallyRetryOn5xx(false); // Don't retry on error.

fetcher_->SetRequestContext(service_->request_context_getter_.get());