Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded Pass() calls Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // A complete set of unit tests for OAuth2AccessTokenFetcherImpl. 5 // A complete set of unit tests for OAuth2AccessTokenFetcherImpl.
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 "{" 54 "{"
55 " \"error\": \"invalid_grant\"" 55 " \"error\": \"invalid_grant\""
56 "}"; 56 "}";
57 57
58 class MockUrlFetcherFactory : public ScopedURLFetcherFactory, 58 class MockUrlFetcherFactory : public ScopedURLFetcherFactory,
59 public URLFetcherFactory { 59 public URLFetcherFactory {
60 public: 60 public:
61 MockUrlFetcherFactory() : ScopedURLFetcherFactory(this) {} 61 MockUrlFetcherFactory() : ScopedURLFetcherFactory(this) {}
62 virtual ~MockUrlFetcherFactory() {} 62 virtual ~MockUrlFetcherFactory() {}
63 63
64 MOCK_METHOD4(CreateURLFetcher, 64 MOCK_METHOD4(CreateURLFetcherMock,
65 URLFetcher*(int id, 65 URLFetcher*(int id,
66 const GURL& url, 66 const GURL& url,
67 URLFetcher::RequestType request_type, 67 URLFetcher::RequestType request_type,
68 URLFetcherDelegate* d)); 68 URLFetcherDelegate* d));
69
70 scoped_ptr<URLFetcher> CreateURLFetcher(int id,
71 const GURL& url,
72 URLFetcher::RequestType request_type,
73 URLFetcherDelegate* d) override {
74 return scoped_ptr<URLFetcher>(
75 CreateURLFetcherMock(id, url, request_type, d));
76 }
69 }; 77 };
70 78
71 class MockOAuth2AccessTokenConsumer : public OAuth2AccessTokenConsumer { 79 class MockOAuth2AccessTokenConsumer : public OAuth2AccessTokenConsumer {
72 public: 80 public:
73 MockOAuth2AccessTokenConsumer() {} 81 MockOAuth2AccessTokenConsumer() {}
74 ~MockOAuth2AccessTokenConsumer() {} 82 ~MockOAuth2AccessTokenConsumer() {}
75 83
76 MOCK_METHOD2(OnGetTokenSuccess, 84 MOCK_METHOD2(OnGetTokenSuccess,
77 void(const std::string& access_token, 85 void(const std::string& access_token,
78 const base::Time& expiration_time)); 86 const base::Time& expiration_time));
(...skipping 21 matching lines...) Expand all
100 URLRequestStatus::Status status = 108 URLRequestStatus::Status status =
101 fetch_succeeds ? URLRequestStatus::SUCCESS : URLRequestStatus::FAILED; 109 fetch_succeeds ? URLRequestStatus::SUCCESS : URLRequestStatus::FAILED;
102 url_fetcher->set_status(URLRequestStatus(status, 0)); 110 url_fetcher->set_status(URLRequestStatus(status, 0));
103 111
104 if (response_code != 0) 112 if (response_code != 0)
105 url_fetcher->set_response_code(response_code); 113 url_fetcher->set_response_code(response_code);
106 114
107 if (!body.empty()) 115 if (!body.empty())
108 url_fetcher->SetResponseString(body); 116 url_fetcher->SetResponseString(body);
109 117
110 EXPECT_CALL(factory_, CreateURLFetcher(_, url, _, _)) 118 EXPECT_CALL(factory_, CreateURLFetcherMock(_, url, _, _))
111 .WillOnce(Return(url_fetcher)); 119 .WillOnce(Return(url_fetcher));
112 return url_fetcher; 120 return url_fetcher;
113 } 121 }
114 122
115 protected: 123 protected:
116 base::MessageLoop message_loop_; 124 base::MessageLoop message_loop_;
117 MockUrlFetcherFactory factory_; 125 MockUrlFetcherFactory factory_;
118 MockOAuth2AccessTokenConsumer consumer_; 126 MockOAuth2AccessTokenConsumer consumer_;
119 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_; 127 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_;
120 OAuth2AccessTokenFetcherImpl fetcher_; 128 OAuth2AccessTokenFetcherImpl fetcher_;
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 TestURLFetcher url_fetcher(0, GURL("http://www.google.com"), NULL); 264 TestURLFetcher url_fetcher(0, GURL("http://www.google.com"), NULL);
257 url_fetcher.SetResponseString(kValidFailureTokenResponse); 265 url_fetcher.SetResponseString(kValidFailureTokenResponse);
258 266
259 std::string error; 267 std::string error;
260 EXPECT_TRUE( 268 EXPECT_TRUE(
261 OAuth2AccessTokenFetcherImpl::ParseGetAccessTokenFailureResponse( 269 OAuth2AccessTokenFetcherImpl::ParseGetAccessTokenFailureResponse(
262 &url_fetcher, &error)); 270 &url_fetcher, &error));
263 EXPECT_EQ("invalid_grant", error); 271 EXPECT_EQ("invalid_grant", error);
264 } 272 }
265 } 273 }
OLDNEW
« no previous file with comments | « google_apis/gaia/oauth2_access_token_fetcher_impl.cc ('k') | google_apis/gaia/oauth2_api_call_flow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698