Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1117663002: Don't run macros or jsmin on extra snapshot scripts (Closed)

Created:
5 years, 7 months ago by domenic
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't run macros or jsmin on extra snapshot scripts js2c.py now distinguishes between the JS internal sources and any extra scripts passed in. The latter only get validation and comment/trailing whitespace removal applied now. Also added a --js option to js2c.py, which will output a JS file instead of a C++ file, for debugging. (I got tired of finding the generated .cc file and extracting its byte array so that I could feed it to a separate helper script I wrote.) R=yangguo@chromium.org, jochen@chromium.org BUG=v8:4064 LOG=N Committed: https://crrev.com/8e2e83f0b37c0ef44c7b7f1892647d3d392e50d4 Cr-Commit-Position: refs/heads/master@{#28133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M tools/js2c.py View 5 chunks +40 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
domenic
5 years, 7 months ago (2015-04-29 12:00:20 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-29 12:09:06 UTC) #2
Yang
On 2015/04/29 12:09:06, jochen wrote: > lgtm Lgtm
5 years, 7 months ago (2015-04-29 12:19:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117663002/1
5 years, 7 months ago (2015-04-29 13:37:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 14:01:40 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 14:01:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e2e83f0b37c0ef44c7b7f1892647d3d392e50d4
Cr-Commit-Position: refs/heads/master@{#28133}

Powered by Google App Engine
This is Rietveld 408576698