Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1117643002: Roll src/third_party/trace-viewer bd416ea:e2b5374 (Closed)

Created:
5 years, 7 months ago by petrcermak
Modified:
5 years, 7 months ago
CC:
chromium-reviews, nduca, dsinclair
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/trace-viewer eea44df:e2b5374 This patch pulls in recent UI fixes and changes for memory-infra. Summary of changes available at: https://chromium.googlesource.com/external/trace-viewer/+log/eea44df..e2b5374 e2b5374 Handle rows with undefined values in memory dump panes properly 3d85362 Change the main allocator metric from inner_size to outer_size 8b89552 Show generic attributes in memory dump UI df1e6c7 generic_object_view table 1eff1ad Fix table builder column setter 210d769 Add support for string attributes in memory allocator dumps 86ab68f Adjust CSS to center 'Monitoring' label 2ce2802 Fix memory dump event timestamps db25ed4 Handle allocators with undefined values in memory dump panes c39a009 Add precise finding code for slices that obeys nesting rules Size increase for resources.pak: 3566 bytes (16958824 -> 16962390) BUG=458295 Committed: https://crrev.com/6887abb9903395bddcba6bbc1b6ba605a13fe531 Cr-Commit-Position: refs/heads/master@{#327480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
petrcermak
This is how we roll...
5 years, 7 months ago (2015-04-29 10:34:34 UTC) #3
Primiano Tucci (use gerrit)
> This is how we roll... Indeed! LGTM
5 years, 7 months ago (2015-04-29 11:25:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117643002/40001
5 years, 7 months ago (2015-04-29 11:26:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 7 months ago (2015-04-29 12:55:08 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 12:56:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6887abb9903395bddcba6bbc1b6ba605a13fe531
Cr-Commit-Position: refs/heads/master@{#327480}

Powered by Google App Engine
This is Rietveld 408576698