Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issue 1117603002: media/midi: Fix warnings found by clang chromium-style plugin on Windows. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
Takashi Toyoshima, Nico
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media/midi: Fix warnings found by clang chromium-style plugin on Windows. http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/631/steps/compile/logs/stdio This fixes the following kind or warnings: warning(clang): [chromium-style] Complex constructor has an inlined body. warning(clang): [chromium-style] Complex destructor has an inline body. After this, "Complex constructor" warnings will be gone, assuming more does not crap in. BUG=467287 R=thakis@chromium.org,toyoshim@chromium.org Committed: https://crrev.com/57d7cbe499248a6ce91ff5b0c954da634cba713c Cr-Commit-Position: refs/heads/master@{#327486}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M media/midi/midi_manager_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/midi/midi_manager_win.cc View 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
tfarina
5 years, 7 months ago (2015-04-29 03:12:03 UTC) #1
Takashi Toyoshima
lgtm. Thanks!
5 years, 7 months ago (2015-04-29 03:20:48 UTC) #2
Nico
lgtm https://codereview.chromium.org/1117603002/diff/1/media/midi/midi_manager_win.cc File media/midi/midi_manager_win.cc (right): https://codereview.chromium.org/1117603002/diff/1/media/midi/midi_manager_win.cc#newcode1100 media/midi/midi_manager_win.cc:1100: midi_service_.reset(); Is the explicit reset() call needed at ...
5 years, 7 months ago (2015-04-29 03:21:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117603002/1
5 years, 7 months ago (2015-04-29 14:09:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 14:13:10 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 14:13:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57d7cbe499248a6ce91ff5b0c954da634cba713c
Cr-Commit-Position: refs/heads/master@{#327486}

Powered by Google App Engine
This is Rietveld 408576698