Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1117583003: [chrome/browser/browsing_data] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, markusheintz_, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/browsing_data module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/c6284dfe312d32542553304da8c147c91b0ed09a Cr-Commit-Position: refs/heads/master@{#327479}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Fixed Review Comments #

Total comments: 3

Patch Set 3 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_quota_helper.h View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_quota_helper.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_quota_helper_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-04-29 06:56:01 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/1117583003/diff/1/chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc File chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc (right): https://codereview.chromium.org/1117583003/diff/1/chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc#newcode7 chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc:7: #include "base/message_loop/message_loop_proxy.h" This include is not necessary anymore. https://codereview.chromium.org/1117583003/diff/1/chrome/browser/browsing_data/browsing_data_quota_helper.h ...
5 years, 7 months ago (2015-04-29 09:25:03 UTC) #3
Pranay
Hi Bernhard, Thanks for the review. Have updated the patch, PTAL.
5 years, 7 months ago (2015-04-29 09:58:52 UTC) #4
Bernhard Bauer
Thanks! https://codereview.chromium.org/1117583003/diff/20001/chrome/browser/browsing_data/browsing_data_quota_helper.h File chrome/browser/browsing_data/browsing_data_quota_helper.h (right): https://codereview.chromium.org/1117583003/diff/20001/chrome/browser/browsing_data/browsing_data_quota_helper.h#newcode19 chrome/browser/browsing_data/browsing_data_quota_helper.h:19: } // namespace base Nit: Two spaces before ...
5 years, 7 months ago (2015-04-29 10:31:34 UTC) #5
Pranay
Sure, fixed Nit :) Thanks
5 years, 7 months ago (2015-04-29 11:14:03 UTC) #6
Bernhard Bauer
LGTM!
5 years, 7 months ago (2015-04-29 11:16:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117583003/40001
5 years, 7 months ago (2015-04-29 12:00:45 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-29 12:53:30 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c6284dfe312d32542553304da8c147c91b0ed09a Cr-Commit-Position: refs/heads/master@{#327479}
5 years, 7 months ago (2015-04-29 12:54:31 UTC) #11
Pranay
Done https://codereview.chromium.org/1117583003/diff/1/chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc File chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc (right): https://codereview.chromium.org/1117583003/diff/1/chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc#newcode7 chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc:7: #include "base/message_loop/message_loop_proxy.h" On 2015/04/29 09:25:02, Bernhard Bauer wrote: ...
5 years, 7 months ago (2015-05-04 03:28:21 UTC) #12
Pranay
5 years, 7 months ago (2015-05-04 03:30:31 UTC) #13
Message was sent while issue was closed. 
https://codereview.chromium.org/1117583003/diff/1/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc
(right):

https://codereview.chromium.org/1117583003/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc:7:
#include "base/message_loop/message_loop_proxy.h"
On 2015/04/29 09:25:02, Bernhard Bauer wrote:
> This include is not necessary anymore.

Done.

https://codereview.chromium.org/1117583003/diff/1/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/browsing_data_quota_helper.h (right):

https://codereview.chromium.org/1117583003/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_quota_helper.h:13: #include
"base/message_loop/message_loop_proxy.h"
On 2015/04/29 09:25:02, Bernhard Bauer wrote:
> This include can be removed.

Done.

https://codereview.chromium.org/1117583003/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_quota_helper.h:15: #include
"base/single_thread_task_runner.h"
On 2015/04/29 09:25:02, Bernhard Bauer wrote:
> You can forward-declare SingleThreadTaskRunner instead of including the whole
> header (see
>
http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Forward...)

Done.

https://codereview.chromium.org/1117583003/diff/20001/chrome/browser/browsing...
File chrome/browser/browsing_data/browsing_data_quota_helper.h (right):

https://codereview.chromium.org/1117583003/diff/20001/chrome/browser/browsing...
chrome/browser/browsing_data/browsing_data_quota_helper.h:19: } // namespace
base
On 2015/04/29 10:31:34, Bernhard Bauer wrote:
> Nit: Two spaces before the comment.

Done.

Powered by Google App Engine
This is Rietveld 408576698