Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1117573002: Fix ChromeOS GN build of content_shell, components_browsertests. (Closed)

Created:
5 years, 7 months ago by Dirk Pranke
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeOS GN build of content_shell, components_browsertests. They had a dependency on //device/bluetooth that wasn't specified and was failing in a shared (component) build. R=scheib@chromium.org TBR=brettw@chromium.org, jochen@chromium.org BUG=463528 Committed: https://crrev.com/93211fc22d04d283f785feb058c0e22b87bc8813 Cr-Commit-Position: refs/heads/master@{#327436}

Patch Set 1 #

Patch Set 2 : make bluetooth an unconditional dep #

Total comments: 2

Patch Set 3 : fix ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Dirk Pranke
5 years, 7 months ago (2015-04-29 00:53:38 UTC) #1
scheib
I'm not sure why this would be only on ChromeOS.
5 years, 7 months ago (2015-04-29 01:09:43 UTC) #2
Dirk Pranke
On 2015/04/29 01:09:43, scheib wrote: > I'm not sure why this would be only on ...
5 years, 7 months ago (2015-04-29 01:10:43 UTC) #3
Dirk Pranke
On 2015/04/29 01:10:43, Dirk Pranke wrote: > On 2015/04/29 01:09:43, scheib wrote: > > I'm ...
5 years, 7 months ago (2015-04-29 01:12:05 UTC) #4
scheib
LGTM https://codereview.chromium.org/1117573002/diff/20001/components/BUILD.gn File components/BUILD.gn (right): https://codereview.chromium.org/1117573002/diff/20001/components/BUILD.gn#newcode363 components/BUILD.gn:363: "//device/bluetooth", Move down to the rest of lines ...
5 years, 7 months ago (2015-04-29 01:15:35 UTC) #5
Dirk Pranke
https://codereview.chromium.org/1117573002/diff/20001/components/BUILD.gn File components/BUILD.gn (right): https://codereview.chromium.org/1117573002/diff/20001/components/BUILD.gn#newcode363 components/BUILD.gn:363: "//device/bluetooth", On 2015/04/29 01:15:35, scheib wrote: > Move down ...
5 years, 7 months ago (2015-04-29 01:19:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117573002/40001
5 years, 7 months ago (2015-04-29 01:19:57 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-29 04:59:49 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 05:00:37 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/93211fc22d04d283f785feb058c0e22b87bc8813
Cr-Commit-Position: refs/heads/master@{#327436}

Powered by Google App Engine
This is Rietveld 408576698