Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1117543003: [chrome/browser/ui] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/ui module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/68aa5e70ff9d3f49745cb4e83af1f4ce99928a56 Cr-Commit-Position: refs/heads/master@{#327654}

Patch Set 1 #

Patch Set 2 : Fixed build break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/image_source.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-04-29 06:13:37 UTC) #2
xiyuan
lgtm
5 years, 7 months ago (2015-04-29 15:57:28 UTC) #3
Pranay
Thanks :)
5 years, 7 months ago (2015-04-29 16:27:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117543003/1
5 years, 7 months ago (2015-04-29 16:27:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/32437)
5 years, 7 months ago (2015-04-29 17:01:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117543003/20001
5 years, 7 months ago (2015-04-30 04:39:35 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-30 05:57:32 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 05:58:41 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68aa5e70ff9d3f49745cb4e83af1f4ce99928a56
Cr-Commit-Position: refs/heads/master@{#327654}

Powered by Google App Engine
This is Rietveld 408576698