Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1117513003: Initializes SecurityPolicy static locals during blink initialization (Closed)

Created:
5 years, 7 months ago by kinuko
Modified:
5 years, 7 months ago
Reviewers:
Mike West
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Initializes SecurityPolicy static locals during blink initialization These static locals could be touched before we initialize threading (which is necessary to call AtomicallyInitializedStaticReference) in chrome build, so simply using AtomicallyInitializedStaticReference doesn't work well. On the other hand in non-chromium build we need to make sure they're initialized before or during the blink initialization. This patch does: - changes AtomicallyInitializedStaticReference back to DEFINE_STATIC_LOCAL - adds explicit SecurityPolicy::init() method and call it in the blink initialization so that static locals are properly initialized regardless of whether it's in chrome build or not. (Note: without this patch chrome starts to crash once we land this patch: https://codereview.chromium.org/1072933006/ and give the whitelisting options) BUG=441605 TEST=green bots Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194750

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M Source/core/Init.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/platform/weborigin/SecurityPolicy.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/weborigin/SecurityPolicy.cpp View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kinuko
Hi Mike, could you review this? It turns out that we couldn't use AtomicallyInitializedStaticReference for ...
5 years, 7 months ago (2015-04-30 13:05:17 UTC) #2
Mike West
LGTM.
5 years, 7 months ago (2015-04-30 16:18:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117513003/20001
5 years, 7 months ago (2015-04-30 16:39:37 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 16:46:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194750

Powered by Google App Engine
This is Rietveld 408576698