tools/testing/run_selenium.py - Issue 11175043: Mark ie10 + Windows as an acceptable browser + OS combo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/run_selenium.py

Issue 11175043: Mark ie10 + Windows as an acceptable browser + OS combo. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/run_selenium.py

===================================================================

--- tools/testing/run_selenium.py (revision 13907)

+++ tools/testing/run_selenium.py (working copy)

@@ -173,7 +173,8 @@

xpi = os.path.join(script_dir, 'extensions', 'firefox', 'ConsoleCollector.xpi')

profile.add_extension(xpi);

return selenium.webdriver.Firefox(firefox_profile=profile)

- elif browser == 'ie9' and platform.system() == 'Windows':

+ elif ((browser == 'ie9' or browser == 'ie10') and

+ platform.system() == 'Windows'):

return selenium.webdriver.Ie()

elif browser == 'safari' and platform.system() == 'Darwin':

# TODO(efortuna): Ensure our preferences (no pop-up blocking) file is the

« no previous file with comments | « no previous file | no next file » | no next file with comments »