Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: lib/html/scripts/systemhtml.py

Issue 11175014: Use CheckSecurityForNode to filter out insecure calls (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/scripts/htmlrenamer.py ('k') | lib/html/scripts/systemnative.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/systemhtml.py
diff --git a/lib/html/scripts/systemhtml.py b/lib/html/scripts/systemhtml.py
index 56182c1907ec43ced0f753adb3bb8848b078954c..5082fe3a0e8a2f5b7ff11481b3944125200aa86f 100644
--- a/lib/html/scripts/systemhtml.py
+++ b/lib/html/scripts/systemhtml.py
@@ -439,13 +439,13 @@ class HtmlDartInterfaceGenerator(object):
def AddAttribute(self, attribute, is_secondary=False):
dom_name = DartDomNameOfAttribute(attribute)
html_name = self._renamer.RenameMember(
- self._interface.id, dom_name, 'get:')
+ self._interface.id, attribute, dom_name, 'get:')
if not html_name or self._IsPrivate(html_name):
return
html_setter_name = self._renamer.RenameMember(
- self._interface.id, dom_name, 'set:')
+ self._interface.id, attribute, dom_name, 'set:')
read_only = (attribute.is_read_only or 'Replaceable' in attribute.ext_attrs
or not html_setter_name)
@@ -477,7 +477,13 @@ class HtmlDartInterfaceGenerator(object):
operations - contains the overloads, one or more operations with the same
name.
"""
- html_name = self._renamer.RenameMember(self._interface.id, info.name)
+ # FIXME: When we pass in operations[0] below, we're assuming all
+ # overloaded operations have the same security attributes. This
+ # is currently true, but we should consider filtering earlier or
+ # merging the relevant data into info itself.
+ html_name = self._renamer.RenameMember(self._interface.id,
+ info.operations[0],
+ info.name)
if not html_name:
if info.name == 'item':
# FIXME: item should be renamed to operator[], not removed.
« no previous file with comments | « lib/html/scripts/htmlrenamer.py ('k') | lib/html/scripts/systemnative.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698