Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1117433003: vs2015: fix pvoid->dword truncation warning (Closed)

Created:
5 years, 7 months ago by scottmg
Modified:
5 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-atomcast
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

vs2015: fix pvoid->dword truncation warning FAILED: ninja -t msvc -e environment.x64 -- "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\base\win\base_static_win64.pe_image.obj.rsp /c ..\..\base\win\pe_image.cc /Foobj\base\win\base_static_win64.pe_image.obj /Fdobj\base\base_static_win64.cc.pdb d:\src\cr2\src\base\win\pe_image.cc(571): error C2220: warning treated as error - no 'object' file generated d:\src\cr2\src\base\win\pe_image.cc(571): warning C4311: 'reinterpret_cast': pointer truncation from 'LPVOID' to 'DWORD' d:\src\cr2\src\base\win\pe_image.cc(571): warning C4302: 'reinterpret_cast': truncation from 'LPVOID' to 'DWORD' d:\src\cr2\src\base\win\pe_image.cc(573): warning C4311: 'reinterpret_cast': pointer truncation from 'PVOID' to 'DWORD' d:\src\cr2\src\base\win\pe_image.cc(573): warning C4302: 'reinterpret_cast': truncation from 'PVOID' to 'DWORD' R=cpu@chromium.org BUG=440500 Committed: https://crrev.com/1f59a1eadbc6a3ab6d03b3c8380a5bc0f83c9eba Cr-Commit-Position: refs/heads/master@{#327404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M base/win/pe_image.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
scottmg
5 years, 7 months ago (2015-04-28 20:32:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117433003/1
5 years, 7 months ago (2015-04-28 20:33:33 UTC) #3
Will Harris
see also crbug.com/390958
5 years, 7 months ago (2015-04-28 20:35:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-28 21:42:41 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm
5 years, 7 months ago (2015-04-29 00:31:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117433003/1
5 years, 7 months ago (2015-04-29 00:33:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 00:36:26 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 00:37:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f59a1eadbc6a3ab6d03b3c8380a5bc0f83c9eba
Cr-Commit-Position: refs/heads/master@{#327404}

Powered by Google App Engine
This is Rietveld 408576698