Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1117433002: Remove GrFlushToGpuDrawTarget and move functionality up to GrDrawTarget. (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrFlushToGpuDrawTarget and move functionality up to GrDrawTarget. Committed: https://skia.googlesource.com/skia/+/a73239a0096370221d3dfababf339dd6d3fed84f

Patch Set 1 #

Patch Set 2 : caps #

Patch Set 3 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -218 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 1 7 chunks +39 lines, -41 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 6 chunks +42 lines, -20 lines 0 comments Download
D src/gpu/GrFlushToGpuDrawTarget.h View 1 chunk +0 lines, -67 lines 0 comments Download
D src/gpu/GrFlushToGpuDrawTarget.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M src/gpu/GrTargetCommands.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 2 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bsalomon
5 years, 7 months ago (2015-04-28 20:14:52 UTC) #2
joshualitt
On 2015/04/28 20:14:52, bsalomon wrote: lgtm
5 years, 7 months ago (2015-04-28 20:26:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117433002/40001
5 years, 7 months ago (2015-04-28 20:29:45 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 20:35:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a73239a0096370221d3dfababf339dd6d3fed84f

Powered by Google App Engine
This is Rietveld 408576698