Issue 111743007: Add the SharedWorker.workerStart property for high resolution timers.

Issue 111743007: Add the SharedWorker.workerStart property for high resolution timers. (Closed)

Created:
6 years, 11 months ago by sof

Modified:
6 years, 11 months ago

Reviewers:
tonyg, adamk, abarth-chromium

CC:
blink-reviews, James Simonsen

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add the SharedWorker.workerStart property for high resolution timers. Update the Worker implementation of the high resolution timer spec (v2), supporting the workerStart attribute which provides the difference between the time origins of a shared worker and the document it is accessed from https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/HighResolutionTime2/Overview.html#sec-worker-start R=tonyg,abarth BUG=169318 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164535

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code style compliance #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -73 lines)			Patch
M	LayoutTests/http/tests/w3c/webperf/submission/Google/HighResolutionTime/worker-dedicated-basic.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/http/tests/w3c/webperf/submission/Google/HighResolutionTime/worker-dedicated-basic-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/http/tests/w3c/webperf/submission/Google/HighResolutionTime/worker-shared-basic.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/http/tests/w3c/webperf/submission/Google/HighResolutionTime/worker-shared-basic-expected.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/workers/SharedWorker.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/modules/modules.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A +	Source/modules/performance/SharedWorkerPerformance.h	View		2 chunks	+17 lines, -25 lines	0 comments	Download
A +	Source/modules/performance/SharedWorkerPerformance.cpp	View	1	2 chunks	+39 lines, -25 lines	0 comments	Download
A +	Source/modules/performance/SharedWorkerPerformance.idl	View		2 chunks	+7 lines, -9 lines	0 comments	Download
M	Source/modules/performance/WorkerGlobalScopePerformance.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/performance/WorkerGlobalScopePerformance.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/modules/performance/WorkerPerformance.h	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/modules/performance/WorkerPerformance.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/modules/performance/WorkerPerformance.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sof

Please take a look whenever you next have a moment. (Perhaps the runtime flag could ...

6 years, 11 months ago (2014-01-06 17:33:39 UTC) #1

tonyg

lgtm But you might want to wait for one or both Adams to take a ...

6 years, 11 months ago (2014-01-06 18:49:06 UTC) #2

adamk

I'll defer to abarth, as this is more about Supplementable (which I'm still working on ...

6 years, 11 months ago (2014-01-06 18:50:53 UTC) #3

abarth-chromium

LGTM https://codereview.chromium.org/111743007/diff/1/Source/modules/performance/SharedWorkerPerformance.cpp File Source/modules/performance/SharedWorkerPerformance.cpp (right): https://codereview.chromium.org/111743007/diff/1/Source/modules/performance/SharedWorkerPerformance.cpp#newcode65 Source/modules/performance/SharedWorkerPerformance.cpp:65: double SharedWorkerPerformance::workerStart(ExecutionContext *context, SharedWorker* sharedWorker) ExecutionContext *context -> ...

6 years, 11 months ago (2014-01-06 22:19:38 UTC) #4

sof

https://codereview.chromium.org/111743007/diff/1/Source/modules/performance/SharedWorkerPerformance.cpp File Source/modules/performance/SharedWorkerPerformance.cpp (right): https://codereview.chromium.org/111743007/diff/1/Source/modules/performance/SharedWorkerPerformance.cpp#newcode65 Source/modules/performance/SharedWorkerPerformance.cpp:65: double SharedWorkerPerformance::workerStart(ExecutionContext *context, SharedWorker* sharedWorker) On 2014/01/06 22:19:39, abarth ...

6 years, 11 months ago (2014-01-06 22:47:20 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/111743007/150001

6 years, 11 months ago (2014-01-06 22:47:34 UTC) #6

Message was sent while issue was closed.

Change committed as 164535

Expand Messages | Collapse Messages