content/renderer/media/rtc_video_decoder.cc - Issue 1117423002: media: Let VideoFrame carry more than one native texture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_video_decoder.cc

Issue 1117423002: media: Let VideoFrame carry more than one native texture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reveman's comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/rtc_video_decoder.cc

diff --git a/content/renderer/media/rtc_video_decoder.cc b/content/renderer/media/rtc_video_decoder.cc

index 74c85e54488906fa61824ff018b5e035b6e7bc08..73df64475e1cc7fc3717a1e887de2d297b8fe7fd 100644

--- a/content/renderer/media/rtc_video_decoder.cc

+++ b/content/renderer/media/rtc_video_decoder.cc

@@ -420,8 +420,7 @@ scoped_refptr<media::VideoFrame> RTCVideoDecoder::CreateVideoFrame(

base::TimeDelta timestamp_ms = base::TimeDelta::FromInternalValue(

base::checked_cast<uint64_t>(timestamp) * 1000 / 90);

return media::VideoFrame::WrapNativeTexture(

- make_scoped_ptr(new gpu::MailboxHolder(pb.texture_mailbox(),

- decoder_texture_target_, 0)),

+ gpu::MailboxHolder(pb.texture_mailbox(), decoder_texture_target_, 0),

media::BindToCurrentLoop(base::Bind(

&RTCVideoDecoder::ReleaseMailbox, weak_factory_.GetWeakPtr(),

factories_, picture.picture_buffer_id(), pb.texture_id())),

« no previous file with comments | « content/renderer/media/android/webmediaplayer_android.cc ('k') | content/renderer/media/video_capture_impl.cc » ('j') | media/base/video_frame.h » ('J')