Implement ScopedTestNSSDB instead of OpenTestNSSDB()

crypto/nss_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/nss_util.h"
 #include "crypto/nss_util_internal.h"
 
 #include <nss.h>
 #include <plarena.h>
 #include <prerror.h>
@@ skipping 684 matching lines @@
     LOG(ERROR) << "Failed to load NSS libraries.";
   }
 #endif
 }
 
 bool CheckNSSVersion(const char* version) {
   return !!NSS_VersionCheck(version);
 }
 
 #if defined(USE_NSS)
-bool OpenTestNSSDB() {
-  return g_nss_singleton.Get().OpenTestNSSDB();
+ScopedTestNSSDB::ScopedTestNSSDB()
+  : is_open_(g_nss_singleton.Get().OpenTestNSSDB()) {
+  DCHECK(is_open_);

[Ryan Sleevi, 2012/10/16 18:19:02]

Do not DCHECK here - this will crash tests in debug mode when it fails, when
what you are expecting is that they will fail (hence why there are the
ASSERT_TRUE results elsewhere)

[Takashi Toyoshima, 2012/10/17 04:58:53]

Done.

+}
+
+ScopedTestNSSDB::~ScopedTestNSSDB() {
+  // TODO(mattm): Close dababase after
+  // https://bugzilla.mozilla.org/show_bug.cgi?id=588269 is fixed.

[Ryan Sleevi, 2012/10/16 18:19:02]

// TODO(mattm): Close the database once NSS 3.14 is required,
// which fixes https://bugzilla.mozilla.org/show_bug.cgi?id=588269

[Takashi Toyoshima, 2012/10/17 04:58:53]

Done.

 }
 
 base::Lock* GetNSSWriteLock() {
   return g_nss_singleton.Get().write_lock();
 }
 
 AutoNSSWriteLock::AutoNSSWriteLock() : lock_(GetNSSWriteLock()) {
   // May be NULL if the lock is not needed in our version of NSS.
   if (lock_)
     lock_->Acquire();
@@ skipping 55 matching lines @@
 
 PK11SlotInfo* GetPublicNSSKeySlot() {
   return g_nss_singleton.Get().GetPublicNSSKeySlot();
 }
 
 PK11SlotInfo* GetPrivateNSSKeySlot() {
   return g_nss_singleton.Get().GetPrivateNSSKeySlot();
 }
 
 }  // namespace crypto