Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 11174003: Use correct newline-token on windows, in pub. (Closed)

Created:
8 years, 2 months ago by Anders Johnsen
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use correct newline-token on windows, in pub. BUG= Committed: https://code.google.com/p/dart/source/detail?r=13678

Patch Set 1 #

Patch Set 2 : Use a more generic approach. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M utils/pub/io.dart View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
Johnni is testing it now.
8 years, 2 months ago (2012-10-16 08:47:08 UTC) #1
kasperl
LGTM, but it might be better to split using a regular expression that allows \n, ...
8 years, 2 months ago (2012-10-16 08:57:49 UTC) #2
Anders Johnsen
Done, PTAL.
8 years, 2 months ago (2012-10-16 09:06:04 UTC) #3
Johnni Winther
8 years, 2 months ago (2012-10-16 09:09:37 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698