Source/web/SpeechRecognitionClientProxy.h - Issue 1117383002: Changing serviceuri param to be url from string in Blink and tagging requests to speech recognizer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/SpeechRecognitionClientProxy.h

Issue 1117383002: Changing serviceuri param to be url from string in Blink and tagging requests to speech recognizer Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding layout tests and forward declaring KURL Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/speech/SpeechRecognition.cpp ('K') | « Source/modules/speech/SpeechRecognitionController.h ('k') | Source/web/SpeechRecognitionClientProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/SpeechRecognitionClientProxy.h

diff --git a/Source/web/SpeechRecognitionClientProxy.h b/Source/web/SpeechRecognitionClientProxy.h

index cca71a1dd2e667c2ddcaa11767dd87f1152ea891..367e2d3d344b28a409757b7b5aa42f84d4d5b2c3 100644

--- a/Source/web/SpeechRecognitionClientProxy.h

+++ b/Source/web/SpeechRecognitionClientProxy.h

@@ -34,6 +34,7 @@

namespace blink {

+class KURL;

class MediaStreamTrack;

class WebSpeechRecognizer;

class WebString;

@@ -47,7 +48,7 @@ public:

static PassOwnPtr<SpeechRecognitionClientProxy> create(WebSpeechRecognizer*);

// SpeechRecognitionClient:

- virtual void start(SpeechRecognition*, const SpeechGrammarList*, const String& lang, const String& serviceURI, bool continuous, bool interimResults, unsigned long maxAlternatives, MediaStreamTrack*) override;

+ virtual void start(SpeechRecognition*, const SpeechGrammarList*, const String& lang, const KURL& serviceURI, bool continuous, bool interimResults, unsigned long maxAlternatives, MediaStreamTrack*) override;

virtual void stop(SpeechRecognition*) override;

virtual void abort(SpeechRecognition*) override;