Source/modules/speech/SpeechRecognitionClient.h - Issue 1117383002: Changing serviceuri param to be url from string in Blink and tagging requests to speech recognizer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/speech/SpeechRecognitionClient.h

Issue 1117383002: Changing serviceuri param to be url from string in Blink and tagging requests to speech recognizer Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding layout tests and forward declaring KURL Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/speech/SpeechRecognition.cpp ('K') | « Source/modules/speech/SpeechRecognition.cpp ('k') | Source/modules/speech/SpeechRecognitionController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/speech/SpeechRecognitionClient.h

diff --git a/Source/modules/speech/SpeechRecognitionClient.h b/Source/modules/speech/SpeechRecognitionClient.h

index 7f6f19ec596f7ae749d9ee744e5ac96221402e6a..384a92b96e2ae1a88ca62b1a0b385b7abddb6ef2 100644

--- a/Source/modules/speech/SpeechRecognitionClient.h

+++ b/Source/modules/speech/SpeechRecognitionClient.h

@@ -31,6 +31,7 @@

namespace blink {

+class KURL;

class Page;

class SpeechGrammarList;

class SpeechRecognition;

@@ -38,7 +39,7 @@ class MediaStreamTrack;

class SpeechRecognitionClient {

public:

- virtual void start(SpeechRecognition*, const SpeechGrammarList*, const String& lang, const String& serviceURI, bool continuous, bool interimResults, unsigned long maxAlternatives, MediaStreamTrack* audioTrack) = 0;

+ virtual void start(SpeechRecognition*, const SpeechGrammarList*, const String& lang, const KURL& serviceURI, bool continuous, bool interimResults, unsigned long maxAlternatives, MediaStreamTrack* audioTrack) = 0;

virtual void stop(SpeechRecognition*) = 0;

virtual void abort(SpeechRecognition*) = 0;