Source/web/SpeechRecognitionClientProxy.cpp - Issue 1117383002: Changing serviceuri param to be url from string in Blink and tagging requests to speech recognizer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/SpeechRecognitionClientProxy.cpp

Issue 1117383002: Changing serviceuri param to be url from string in Blink and tagging requests to speech recognizer Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removing the exception on invalid urls, adding chromium to client param of serviceURI, and changing… Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/SpeechRecognitionClientProxy.cpp

diff --git a/Source/web/SpeechRecognitionClientProxy.cpp b/Source/web/SpeechRecognitionClientProxy.cpp

index 33632ed4114b84f8ef828d24f56dd935647740ec..163796afb7951459cdd97f7d6e1c0bc2afd70226 100644

--- a/Source/web/SpeechRecognitionClientProxy.cpp

+++ b/Source/web/SpeechRecognitionClientProxy.cpp

@@ -55,7 +55,7 @@ PassOwnPtr<SpeechRecognitionClientProxy> SpeechRecognitionClientProxy::create(We

return adoptPtr(new SpeechRecognitionClientProxy(recognizer));

}

-void SpeechRecognitionClientProxy::start(SpeechRecognition* recognition, const SpeechGrammarList* grammarList, const String& lang, const String& serviceURI, bool continuous, bool interimResults, unsigned long maxAlternatives, MediaStreamTrack* audioTrack)

+void SpeechRecognitionClientProxy::start(SpeechRecognition* recognition, const SpeechGrammarList* grammarList, const String& lang, const KURL& serviceURI, bool continuous, bool interimResults, unsigned long maxAlternatives, MediaStreamTrack* audioTrack)

{

WebVector<WebSpeechGrammar> webSpeechGrammars(static_cast<size_t>(grammarList->length()));

for (unsigned long i = 0; i < grammarList->length(); ++i)

« no previous file with comments | « Source/web/SpeechRecognitionClientProxy.h ('k') | public/web/WebSpeechRecognitionParams.h » ('j') | no next file with comments »